Mixmix/new sdk rc #263
Merged
Mixmix/new sdk rc #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Oct 22, 2024
| const { entropy: naynay } = await setupTest(t, { networkType }) | ||
| // await run('jump-start network', jumpStartNetwork(entropy)) | ||
| const { run, entropy: naynay } = await setupTest(t) | ||
| await run('fund naynay', fundAccount(t, naynay)) |
There was a problem hiding this comment.
I loved the pattern you started extracting some other setup. I noticed that we want a funded account which is just "set up" for us and that extracting it made the tests a whole lot simpler (to my mind any way)
mixmix
commented
Oct 22, 2024
tests/faucet.test.ts
Outdated
Comment on lines
15
to
17
| const transfer = new EntropyTransfer(entropy, endpoint) | ||
| const account = new EntropyAccount(entropy, endpoint) | ||
| const faucet = new EntropyFaucet(entropy, endpoint) |
There was a problem hiding this comment.
less words means less reading. I'm pretty happy we're not gonna get collisions and am watching closely for that
There was a problem hiding this comment.
the rest of this file, I shuffled lines around such that there are groupings like
- prep
- action
- test
- prep
- action
- test
This is fully an opinionated style thing, but it makes reading quicker because the relevant context is grouped into parcels. 🤷
mixmix
commented
Oct 22, 2024
mixmix
force-pushed
the
mixmix/new-sdk-rc
branch
from
6cbc5e5
to
0ae60f2
Compare
mixmix
force-pushed
the
mixmix/new-sdk-rc
branch
from
0ae60f2
to
ce45b24
Compare
rh0delta
requested changes
Oct 22, 2024
Co-authored-by: Nayyir Jutha <nayyir.jutha@gmail.com>
Co-authored-by: Nayyir Jutha <nayyir.jutha@gmail.com>
|
Thanks for the review, Good catches you made there. |
rh0delta
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tweeeeks
this PR is just test readability. Sometimes when I'm reviewing I have to move things into chunks of related logic to be able to follow the logic. Thought I'd post the changes and see you agree
there is 1 test where I sharpen the test to an exact value